Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SharedMutex improve #244

Merged
merged 3 commits into from
Dec 7, 2023
Merged

SharedMutex improve #244

merged 3 commits into from
Dec 7, 2023

Conversation

MBkkt
Copy link
Member

@MBkkt MBkkt commented Dec 6, 2023

Purpose

  • Make unlock_shared fully wait-free
  • Avoid computing writers size twice
  • Inline list implementation to keep less instruction in lock critical section

Related Information

  • Design document: ...
  • Bench PR: ...

Testing

  • This change is a trivial rework or code cleanup without any test coverage.
  • This change is already covered by existing tests.
  • This PR adds tests that were used to verify all changes.
  • There are tests in an external testing repository: ...

@MBkkt MBkkt requested a review from kononovk as a code owner December 6, 2023 03:45
@MBkkt MBkkt self-assigned this Dec 6, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7109904397

  • 30 of 30 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 6956551694: 0.0%
Covered Lines: 1741
Relevant Lines: 1741

💛 - Coveralls

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0acd8f) 100.00% compared to head (d5ee098) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #244   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           73        73           
  Lines         1730      1741   +11     
=========================================
+ Hits          1730      1741   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MBkkt MBkkt merged commit d9c3506 into main Dec 7, 2023
39 of 40 checks passed
@MBkkt MBkkt deleted the rw-mutex-improve branch December 7, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants