Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add professor courses informations #833

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

add professor courses informations #833

wants to merge 13 commits into from

Conversation

RonglinC
Copy link

Issue

Note which issue number(s) this Pull Request closes. All pull requests should close an issue, if one does not exists, make one. This helps us plan and discuss before we decide on implementation

Example:

closes #806

Database Changes/Migrations
N/A

Test Modifications
scrape the information of professor's teaching courses and put into json file then put it into the website page.

Test Procedure

  1. Create a branch
  2. Commit a change to that branch
  3. Push branch
  4. Create Pull Request and fill in PR template

Photos
Before:
image
after:
Show before and after, capture screenshot/gif of finished feature/bug
image

Additional Info

More info that would help people review your change

@RonglinC RonglinC changed the title #806 issue add professor courses informations Oct 27, 2023
@dorian451 dorian451 assigned dorian451 and RonglinC and unassigned dorian451 Oct 27, 2023
Copy link
Contributor

@dorian451 dorian451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great way to show how the teaching history of each professor, but most of them say "not available". I'm thinking a better of way of actually getting the info would be querying our database

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request — see what courses a professor teaches in the professor page
2 participants