Skip to content

Commit

Permalink
vm: fix vm_pgoff wrap in upward expansion
Browse files Browse the repository at this point in the history
Commit a626ca6 ("vm: fix vm_pgoff wrap in stack expansion") fixed
the case of an expanding mapping causing vm_pgoff wrapping when you had
downward stack expansion.  But there was another case where IA64 and
PA-RISC expand mappings: upward expansion.

This fixes that case too.

Signed-off-by: Hugh Dickins <hughd@google.com>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Hugh Dickins authored and torvalds committed May 10, 2011
1 parent c191f6c commit 42c36f6
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions mm/mmap.c
Original file line number Diff line number Diff line change
Expand Up @@ -1767,10 +1767,13 @@ int expand_upwards(struct vm_area_struct *vma, unsigned long address)
size = address - vma->vm_start;
grow = (address - vma->vm_end) >> PAGE_SHIFT;

error = acct_stack_growth(vma, size, grow);
if (!error) {
vma->vm_end = address;
perf_event_mmap(vma);
error = -ENOMEM;
if (vma->vm_pgoff + (size >> PAGE_SHIFT) >= vma->vm_pgoff) {
error = acct_stack_growth(vma, size, grow);
if (!error) {
vma->vm_end = address;
perf_event_mmap(vma);
}
}
}
vma_unlock_anon_vma(vma);
Expand Down

0 comments on commit 42c36f6

Please sign in to comment.