Skip to content

Commit

Permalink
Input: ir-keytable - fix uninitialized variable warning
Browse files Browse the repository at this point in the history
We were forgetting to set up proper return value in success path causing
ir_getkeycode() to fail intermittently:

drivers/media/IR/ir-keytable.c: In function 'ir_getkeycode':
drivers/media/IR/ir-keytable.c:363: warning: 'retval' may be used
uninitialized in this function

Reported-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
dtor authored and torvalds committed Nov 1, 2010
1 parent 50440c6 commit 47c5ba5
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/media/IR/ir-keytable.c
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,8 @@ static int ir_getkeycode(struct input_dev *dev,
ke->len = sizeof(entry->scancode);
memcpy(ke->scancode, &entry->scancode, sizeof(entry->scancode));

retval = 0;

out:
spin_unlock_irqrestore(&rc_tab->lock, flags);
return retval;
Expand Down

0 comments on commit 47c5ba5

Please sign in to comment.