Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 프론트엔드 건의사항 반영 #47 #48

Merged
merged 3 commits into from
Jul 4, 2022
Merged

fix: 프론트엔드 건의사항 반영 #47 #48

merged 3 commits into from
Jul 4, 2022

Conversation

kang-jisu
Copy link
Contributor

@kang-jisu kang-jisu commented Jul 3, 2022 •
edited

이슈

작업 내용

  • 유저나무숲 조회 응답에 열매 타입 추가
  • 나무 편집 API 응답으로 편집된 나무 id 반환
  • 물주기 요청 DTO 스웨거 문서 설명 추가

기타 사항

  • 유저 나무 목록 API는 이야기가 좀 더 필요해보입니다 .. -> 유저 나무숲 조회와 함께 쓰는걸로 결론났습니다!

체크리스트

  • 테스트코드 성공 확인

@kang-jisu kang-jisu added 💡feature API feature 🌲칭찬 칭찬 labels Jul 3, 2022
@kang-jisu kang-jisu self-assigned this Jul 3, 2022
@kang-jisu kang-jisu added this to To do in BeTree via automation Jul 3, 2022
@kang-jisu kang-jisu requested a review from suubinkim July 3, 2022 13:20
@kang-jisu kang-jisu mentioned this pull request Jul 3, 2022
Closed
@kang-jisu kang-jisu changed the title fix: 프론트엔드 건의사항 반영 fix: 프론트엔드 건의사항 반영 #47 Jul 3, 2022
suubinkim
suubinkim reviewed Jul 4, 2022
View reviewed changes
Copy link
Member

@suubinkim suubinkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ LGTM ❤️

@suubinkim suubinkim merged commit c42ca71 into YAPP-Github:develop Jul 4, 2022
BeTree automation moved this from To do to Done Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suubinkim suubinkim suubinkim left review comments

Assignees

@kang-jisu kang-jisu

Labels
🌲칭찬 칭찬 💡feature API feature
Projects
BeTree
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kang-jisu @suubinkim