Design: 인증 / 설문 레이아웃 #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeong-jeong
approved these changes
May 29, 2022
Jeong-jeong
approved these changes
May 29, 2022
| <NavigationWrapper> | ||
| {hasProgressBar && <ProgressBar currStep={currStep} totalStep={totalStep} />} | ||
| <ButtonWrapper> | ||
| <Button size="large" variant="gray"> |
There was a problem hiding this comment.
Suggested change
| <Button size="large" variant="gray"> | |
| <Button size="medium" variant="gray"> |
| </Button> | ||
| <Button | ||
| onClick={() => console.log('aa')} | ||
| size="large" |
There was a problem hiding this comment.
Suggested change
| size="large" | |
| size="medium" |
Comment on lines
+48
to
+49
| font-family: SangjuGotgam, Pretendard Variable, -apple-system, BlinkMacSystemFont, system-ui, Roboto, 'Helvetica Neue', 'Segoe UI', | ||
| 'Apple SD Gothic Neo', 'Noto Sans KR', 'Malgun Gothic', 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol', sans-serif; |
There was a problem hiding this comment.
Logo 폰트 패밀리가 기존과 다른가요? 아니면 theme이나 공통된 곳에서 사용하는 것이 좋을 것 같아요!
There was a problem hiding this comment.
로고가 SangjuGotgam 폰트여서 기존 폰트에서 SangjuGotgam만 추가했습니다..!
로고 폰트는 여기서만 쓰이는거 같아서 바로 썼는데 theme에 넣어두는게 나을까요??
요거 수정은 다음 작업할 때 같이 하고 머지 먼저 하겠습니다~
| 'Apple SD Gothic Neo', 'Noto Sans KR', 'Malgun Gothic', 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol', sans-serif; | ||
| font-weight: 400; | ||
| font-size: 14px; | ||
| line-height: 125%; |
There was a problem hiding this comment.
line-height는 %값을 쓰는군요! 신기합니다
There was a problem hiding this comment.
이거는 피그마에 있는대로 가져온것인데 저도 %는 처음 써본거같네요 ㅎㅎ
https://webclub.tistory.com/631
|
저도 나중에 소개팅 부분까지 고려하면 많이 복잡해질 것 같아서 2번으로 하는게 더 깔끔하지 않을까 생각합니다 |
leejiho9898
approved these changes
May 29, 2022
| return ( | ||
| <> | ||
| <HeaderWrapper> | ||
| <Logo to="/">외딴썸</Logo> |
There was a problem hiding this comment.
로고 부분은 이미지로 하실 줄 알았는데 폰트를 바꿔서 하는 방법도 있었군요 👍
|
넵!! 2번으로 가는것으로 하겠습니다! 리뷰 감사합니다~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑💻 PR 내용
의견
저는 설문이 많아서 2번이 덜 복잡해지지 않을까 싶기도 한데 1번도 컴포넌트를 잘 해두면 괜찮을것 같아서 고민이 되네요 🤔🤔
📸 스크린샷
템플릿 안에 내용은 임의로 넣어둔것입니다!