Merge YAXLib.Redux v2 #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
304NotModified
requested changes
Mar 4, 2021
YAXLib/YAXLib.csproj
Outdated
| </PropertyGroup> | ||
| <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|netstandard2.0|AnyCPU'"> | ||
| <DefineConstants>TRACE</DefineConstants> | ||
| <PackageTags>XML Serialization Serializer Serialize .NET Core</PackageTags> |
There was a problem hiding this comment.
Is this on purpose?
There was a problem hiding this comment.
PackageTags ? These are the NuGet tags.
axunonb
reviewed
Mar 4, 2021
axunonb
reviewed
Mar 4, 2021
axunonb
reviewed
Mar 4, 2021
|
Sorry for the conflicts. Did not expect that after merging the other PR. |
NKnusperer
force-pushed
the
feature/merge-yaxlib.redux-v2
branch
from
adac923
to
043dd28
Compare
NKnusperer
force-pushed
the
feature/merge-yaxlib.redux-v2
branch
4 times, most recently
from
7c2a654
to
2c9fe2b
Compare
|
Please review the rebased pr. |
axunonb
reviewed
Mar 5, 2021
NKnusperer
force-pushed
the
feature/merge-yaxlib.redux-v2
branch
from
2c9fe2b
to
b9128a2
Compare
|
Thanks! Will try to review this weekend |
304NotModified
approved these changes
Mar 9, 2021
|
@axunonb agree with merge of this one? |
axunonb
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework of #120 excluding newline normalization and coding style changes.