Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix YAXAttributeForClass and YAXValueForClass attributes are ignored when a YAXCustomSerializer is not defined on the property's type #143

Merged
merged 2 commits into from Apr 5, 2021
Merged

Fix YAXAttributeForClass and YAXValueForClass attributes are ignored when a YAXCustomSerializer is not defined on the property's type #143

merged 2 commits into from Apr 5, 2021

Conversation

axunonb
Copy link
Collaborator

@axunonb axunonb commented Apr 5, 2021

@axunonb axunonb added this to the v3 milestone Apr 5, 2021
@axunonb axunonb changed the title Customer serializer issue 97 Custom serializer issue 97 Apr 5, 2021
@304NotModified 304NotModified changed the title Custom serializer issue 97 Fix YAXAttributeForClass attribute is ignored when a YAXCustomSerializer is defined on the property's type Apr 5, 2021
@304NotModified
Copy link
Collaborator

Renamed the PR for the changelog later. I hope this is correct

@axunonb axunonb changed the title Fix YAXAttributeForClass attribute is ignored when a YAXCustomSerializer is defined on the property's type Fix YAXAttributeForClass and YAXValueForClass attributes are ignored when a YAXCustomSerializer is not defined on the property's type Apr 5, 2021
@axunonb axunonb merged commit 4789901 into YAXLib:master Apr 5, 2021
@axunonb axunonb deleted the Customer_Serializer_Issue_97 branch April 6, 2021 20:36
@304NotModified
Copy link
Collaborator

Great work!

304NotModified added a commit that referenced this pull request Apr 7, 2021
@304NotModified
Fix link description #143
9e4ca6b
axunonb added a commit that referenced this pull request Jun 21, 2021
@axunonb
Update change log for v3 + rc.1 release (#145)
71690b6 
* Update change log for v3
* Fix link description #143
* Updated for #147
* Set version to 3.0.0-rc1 in appveyor.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@304NotModified 304NotModified 304NotModified approved these changes

@NKnusperer NKnusperer Awaiting requested review from NKnusperer

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
v3
Development

Successfully merging this pull request may close these issues.

YAXAttributeForClass attribute is ignored when a YAXCustomSerializer is defined on the property's type
2 participants
@axunonb @304NotModified