Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked how the API shutdown worked #151

Merged
merged 1 commit into from
Mar 25, 2023
Merged

Conversation

RealYusufIsmail
Copy link
Member

Pull Request Etiquette

  • I have checked the PRs for upcoming features/bug fixes.
  • I have read the code of conduct.

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes : NaN

Description

Replace this sentence with general description of what your Pull Request does.

@RealYusufIsmail RealYusufIsmail self-assigned this Mar 25, 2023
@RealYusufIsmail RealYusufIsmail enabled auto-merge (squash) March 25, 2023 11:15
@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

Patch coverage: 4.25% and project coverage change: -0.61 ⚠️

Comparison is base (0d9076c) 2.10% compared to head (52852c4) 1.50%.

Additional details and impacted files
@@             Coverage Diff             @@
##             master    #151      +/-   ##
===========================================
- Coverage      2.10%   1.50%   -0.61%     
+ Complexity       19      14       -5     
===========================================
  Files           205     205              
  Lines          3416    3396      -20     
  Branches        403     403              
===========================================
- Hits             72      51      -21     
- Misses         3340    3341       +1     
  Partials          4       4              
Impacted Files Coverage Δ
src/main/kotlin/io/github/ydwk/ydwk/BotBuilder.kt 0.00% <0.00%> (ø)
.../kotlin/io/github/ydwk/ydwk/ws/WebSocketManager.kt 0.00% <0.00%> (ø)
...in/kotlin/io/github/ydwk/ydwk/ws/util/CloseCode.kt 0.00% <0.00%> (ø)
...c/main/kotlin/io/github/ydwk/ydwk/impl/YDWKImpl.kt 21.23% <4.54%> (-0.72%) ⬇️
...ydwk/evm/backend/managers/CoroutineEventManager.kt 40.74% <50.00%> (+2.27%) ⬆️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RealYusufIsmail RealYusufIsmail merged commit 5402fce into master Mar 25, 2023
@RealYusufIsmail RealYusufIsmail deleted the shutdown-fix branch March 25, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant