Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made onEvent functions suspend #172

Merged
merged 1 commit into from
Jul 30, 2023
Merged

made onEvent functions suspend #172

merged 1 commit into from
Jul 30, 2023

Conversation

RealYusufIsmail
Copy link
Member

Pull Request Etiquette

  • I have checked the PRs for upcoming features/bug fixes.
  • I have read the code of conduct.

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes : #168

@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.63% ⚠️

Comparison is base (476f492) 1.63% compared to head (d74da9b) 1.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##             master    #172      +/-   ##
===========================================
- Coverage      1.63%   1.00%   -0.63%     
+ Complexity       15       8       -7     
===========================================
  Files           197     197              
  Lines          3188    3194       +6     
  Branches        311     311              
===========================================
- Hits             52      32      -20     
- Misses         3132    3161      +29     
+ Partials          4       1       -3     
Files Changed Coverage Δ
...ydwk/evm/backend/managers/CoroutineEventManager.kt 10.71% <0.00%> (-30.03%) ⬇️
...wk/ydwk/evm/backend/managers/SampleEventManager.kt 11.76% <ø> (-17.65%) ⬇️
...c/main/kotlin/io/github/ydwk/ydwk/impl/YDWKImpl.kt 14.40% <0.00%> (-7.72%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RealYusufIsmail RealYusufIsmail merged commit 8f77dfb into master Jul 30, 2023
11 of 13 checks passed
@RealYusufIsmail RealYusufIsmail deleted the suspend-function branch July 30, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the generative onEvent methods async
1 participant