-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed YDE and breaking changes #211
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also bumped license year
Also removed deprected use in gradle
RealYusufIsmail
changed the title
Reworked full YDE and YDWK lib
Embed YDE and breaking changes
Apr 4, 2024
This pull request is stale because it has been open 40 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summery
This pr aims to embed YDE lib into this repo in order for any changes to be reflected immediately in YDWK.
This as a result means that they all share one common gradle now.
YDE has also been split into two parts yde-api and yde-impl.
Majority class in impl are now internal.
This pr contains a hall list of breaking changes which include
Job
All these changes aim to enhance the libraries performance and improve its list of features.
All these changes will be released under version 2.0.0-alpha.1
All other changes for version 2.0.0 such as full completion of entries and a fix to the voice system will be aimed to integrated in later prs.
See #169