Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed YDE and breaking changes #211

Closed
wants to merge 53 commits into from
Closed

Embed YDE and breaking changes #211

wants to merge 53 commits into from

Conversation

RealYusufIsmail
Copy link
Member

@RealYusufIsmail RealYusufIsmail commented Mar 21, 2024

Summery

This pr aims to embed YDE lib into this repo in order for any changes to be reflected immediately in YDWK.

This as a result means that they all share one common gradle now.

YDE has also been split into two parts yde-api and yde-impl.

Majority class in impl are now internal.

This pr contains a hall list of breaking changes which include

  • Integrated OkHttp with ktor
  • All impls now import all variables in the constructor.
  • All impls are called in the new EntityInstanceBuilderImpl class
  • Majority of impls apart from some such as YDEImpl are now internal classes
  • Reworked Message interaction system.
  • Remove deprecated event method.
  • A full cleanup of incorrect or outdated fields
  • Improved the way websocket handles future. Uses Kotlins Job
  • Added ability to call event listeners through
ydwk onSlasCommandEvent {}

All these changes aim to enhance the libraries performance and improve its list of features.

All these changes will be released under version 2.0.0-alpha.1

All other changes for version 2.0.0 such as full completion of entries and a fix to the voice system will be aimed to integrated in later prs.

See #169

@RealYusufIsmail RealYusufIsmail removed a link to an issue Apr 4, 2024
8 tasks
@RealYusufIsmail RealYusufIsmail mentioned this pull request Apr 4, 2024
8 tasks
@RealYusufIsmail RealYusufIsmail changed the title Reworked full YDE and YDWK lib Embed YDE and breaking changes Apr 4, 2024
Copy link

This pull request is stale because it has been open 40 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use MockK to mock the HttpClient
1 participant