Skip to content
This repository has been archived by the owner on Jan 28, 2022. It is now read-only.

Improvments for less drain of battery and during reconnection #20

Merged
merged 5 commits into from
Jan 10, 2021
Merged

Improvments for less drain of battery and during reconnection #20

merged 5 commits into from
Jan 10, 2021

Conversation

miloit
Copy link
Contributor

@miloit miloit commented Jan 6, 2021

Changed the mechanism of reconnection
Delete the polling timer to drain less batterie

OH3 compatible now with setting the token option in the config file
Delete the polling timer to drain less batterie
@miloit miloit changed the title Improvments for less drrain of battery and during reconnection Improvments for less drain of battery and during reconnection Jan 6, 2021
@zehnm zehnm self-requested a review January 10, 2021 15:03
@zehnm zehnm added this to Implementation in YIO Remote software via automation Jan 10, 2021
@zehnm zehnm moved this from Implementation to Code review in YIO Remote software Jan 10, 2021
Copy link
Member

@zehnm zehnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvements, especially for getting rid of the curl execution.
Just a few minor things, otherwise I can't say much to the OH functionality. Haven't used it so far.

src/openhab.cpp Show resolved Hide resolved
src/openhab.cpp Outdated Show resolved Hide resolved
src/openhab.cpp Outdated Show resolved Hide resolved
src/openhab.cpp Outdated Show resolved Hide resolved
src/openhab.cpp Outdated Show resolved Hide resolved
@miloit miloit requested a review from zehnm January 10, 2021 17:32
YIO Remote software automation moved this from Code review to Reviewer approved Jan 10, 2021
@zehnm zehnm merged commit 46d507e into YIO-Remote:master Jan 10, 2021
YIO Remote software automation moved this from Reviewer approved to Done Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants