Clear items to show resize timeout when component unmounts (Issue #87) #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the window is resized, timeout(s) with setState are set; these need to be cleaned up on unmount to prevent a potential memory leak
Closed
TheKidCoder
approved these changes
Sep 1, 2020
chrisinajar
approved these changes
Sep 1, 2020
|
@all-contributors please add @rlundquist3 for code |
|
I've put up a pull request to add @rlundquist3! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in issue #87 , there is an occasional error indicating a memory leak occasionally when the component mounts, especially (but not exclusively) when resizing.
Clearing this/these timeout(s) on unmount prevents the error.
Error:
To most easily reproduce the problem without this change, resize the window while the page is loading.