Added Fix for using tab to slide through the carousel list #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, remind me to test it and merge it |
YIZHUANG
approved these changes
May 11, 2021
|
@YIZHUANG Reminder to test and merge this fix. |
|
@YIZHUANG Merge & Test reminder |
|
@YIZHUANG Reminder to test and merge |
|
Hello, @YIZHUANG! I'd be very interested in a fix for this issue. Is there anything I might do to help get this merged in? Thanks! |
YIZHUANG
approved these changes
May 20, 2021
|
It's published at 2.6.3 |
|
@all-contributors please add @tegaadigu for code |
|
I've put up a pull request to add @tegaadigu! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the accessibility issue raised in #233 (comment) and #242
Summary:
Describe the bug
Hello, thank you for such a great library, it helps me a lot, but recently I have stumbled upon the following bug. The carousel arrows do not get updated when navigating the carousel with keyboard focus - TAB.
To Reproduce
Steps to reproduce the behaviour:
Go to https://w3js.com/react-multi-carousel
After the example loads, click on the first carousel item
Press TAB multiple times on the keyboard to change focus to the next carousel items.
See how the arrows on the carousel stay at the same place despite the carousel being moved to another item.
Expected behaviour
The position of arrows should be updated.
Fix
This fix also limits Arrow key control which tends to move all Carousel present in a given page to only active / selected carousel. See Gif below for working fix