New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple Bookmarklets and twice "https" trim problem #2773

Closed

jaialai2002 opened this issue Oct 20, 2020 · 3 comments

Labels

bug

jaialai2002 commented Oct 20, 2020

The simple Bookmarklets its a great feature but I find a problem when shortening certain URLs that contain twice "https".
A long URL as https://server.knosys.es/_sefarad_wp2/pdfjs/viewer/viewer.vm?src=https://server.knosys.es/sefarad_pdf/1918_Derecho_de_los_judios_de_Castilla.pdf is coded as https://server.knosys.es/_sefarad_wp2/pdfjs/viewer/viewer.vm?src=

The simple Bookmarklets trims part of the URL to the start of the second "https"
Is there an easy fix?
Thanks,
Jaime

jaialai2002 added the bug label

Member

ozh commented Oct 20, 2020

Yeah, known issue, see #1672, bookmarklets will fail when encountering multiple "http(s)://"

The fix would be to use a custom bookmarklet as I describe in 1672

Member

ozh commented Oct 20, 2020

Although in your specific case, you can use a relative URL: https://server.knosys.es/_sefarad_wp2/pdfjs/viewer/viewer.vm?src=/sefarad_pdf/1918_Derecho_de_los_judios_de_Castilla.pdf seems to work fine

Author

jaialai2002 commented Oct 20, 2020

Thank you very much. I imagine it would be a complicated bookmarklt. I will consider your second suggestion

ozh closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment