Correcting title attr. of display_link #2075
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a minor glitch in
edit_link_save
in insert.js:Problem / How to reproduce:
After edition of an URL's title, the
title
attribute of the display title (as visible on hovering the display title) is replaced by the (untrimmed) long URL. This is unexpected/inconsistent behavior [behaviour] since in contrast, for an existing unedited URL title, the respectivetitle
attribute is simply the (untrimmed) title itself (see the line'title_attr' => yourls_esc_attr( $title ),
inyourls_table_add_row
in functions-html.php: cf.YOURLS/includes/functions-html.php
Line 561 in cb86f5b
Fix:
Plugging in
data.url.title
as (untrimmed)title
attribute (instead of plugging indata.url.url
) when setting the variabledisplay_link
.