Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash app when trying to edit the title of a page that has a hierarchy and links to other pages in the title #50

Closed
mbelanger2 opened this issue Jan 24, 2024 · 5 comments
Assignees
Labels
type: bug Something isn't working

Comments

@mbelanger2
Copy link

logseq crash when trying to edit the title of a page that has links to other pages in the title. Logseq does not crash when the plugin isn't installed.

By mistake (copy/paste), I created a page with links to other pages in the title.
When I try to edit the title, logseq show the "Something went wrong" screen.

  1. Create a page named [[test/Level1]]
  2. Create a page named [[[[test/Level1]] will it crash?]]
  3. Open that last page
  4. Try to edit the title.

I know that we don't need pages with links in the title. We should not be able to create them. But since we can, the plugin should no crash if it encounter them.
Logseq_hierarchyCrash

@mbelanger2
Copy link
Author

This is a really low priority. As I said, we don't need pages with links in the title, so this issue will be really rare.

@YU000jp
Copy link
Owner

YU000jp commented Jan 25, 2024

It is a bug. Thank you for creating a screenshot that clearly reproduces the bug. I have a similar problem with unnecessary links. I would like to avoid crashes.

@YU000jp YU000jp added the type: bug Something isn't working label Jan 25, 2024
github-actions bot pushed a commit that referenced this issue Jan 30, 2024
# [2.22.0](v2.21.0...v2.22.0) (2024-1-30)

### Bug Fixes

* **bug:** Crashes when the page name contains "[[" and "]]" [#50](#50) ([3cd0293](3cd0293))

### Features

* **translations:** for plugin settings ([8b88a59](8b88a59))
@YU000jp
Copy link
Owner

YU000jp commented Jan 30, 2024

I released a new version. It will now be canceled if the page name contains "[[" and "]]". Thank you!

@YU000jp
Copy link
Owner

YU000jp commented Jan 30, 2024

In the future, I plan to create a plugin to delete pages with "[[" and "]]" in the page name. After 1 minute of the plugin running, it will delete those pages. Deletion will also occur after 1 hour. In this case, the page that contains "[[" and "]]" is assumed to be unnecessary and executed.

@YU000jp
Copy link
Owner

YU000jp commented Feb 25, 2024

In the future, I plan to create a plugin to delete pages with "[[" and "]]" in the page name. After 1 minute of the plugin running, it will delete those pages. Deletion will also occur after 1 hour. In this case, the page that contains "[[" and "]]" is assumed to be unnecessary and executed.

Added to Innovation Lab plugin

@YU000jp YU000jp closed this as completed Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants