Fixed case when bxt_remove_fps_limit code is active if cheats disabled #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaLTeR
reviewed
Oct 17, 2022
YaLTeR
requested changes
Oct 28, 2022
BunnymodXT/modules/HwDLL.cpp
Outdated
| } | ||
| else if (*reinterpret_cast<byte*>(pHost_FilterTime_FPS_Cap_Byte) == 0xEB) | ||
|
|
||
| if (CVars::bxt_remove_fps_limit.GetBool() && ((is_0x7E && CVars::sv_cheats.GetBool()) || is_0x75)) |
There was a problem hiding this comment.
Why is the sv_cheats check only in 0x7E case?
There was a problem hiding this comment.
Uh, let me explain what these two cases do:
- 0x75 (1712-WON pattern) unlocks a cap for a higher FPS (not needed in
sv_cheatstbh) - 0x7E (Steam pattern) unlocks a cap for set a <20 FPS if
maxplayers > 1(it really needssv_cheatsas I don't want anyone to use it on normal servers, the reason why I even added this is for funny local sessions with friends in co-op modifications for GoldSrc engine, e.g.: https://www.moddb.com/mods/blue-shift-coop/downloads)
YaLTeR
reviewed
Nov 3, 2022
|
Alright, I guess it's good now. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.