-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CS1.6 related changes for TAS Optimizer #50
Conversation
bxt-rs/bxt-strafe/src/steps.rs Lines 730 to 732 in 576e012
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but needs a few improvements.
Thanks, this seems reasonable. Let me do that. |
This has all the changes except the unresolved one, not sure how it would proceed 👍 |
let max_speed = get_cvar_f32(marker, "sv_maxspeed").unwrap_or(320.); | ||
let client_max_speed = engine::pmove | ||
.get_opt(marker) | ||
.map(|pmove| (**pmove).clientmaxspeed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see BXT uses GetClientMaxspeed()
for this. I'm not sure using pmove
is equivalent, isn't it one frame off? Since pmove
is only filled/updated later in the frame.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not aware of it being one frame off. It does sync well on my end. If it is one frame off then it would be one frame off the very first frame of the TAS as weapon speed would be the same the whole run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, it is in the bind, so I just use whatever is there.
Thanks! |
Hmmm, it doesn't look up to standard from my standard.