Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: check nix build works #180

Merged
merged 1 commit into from
Feb 12, 2024
Merged

CI: check nix build works #180

merged 1 commit into from
Feb 12, 2024

Conversation

KiaraGrouwstra
Copy link
Contributor

@KiaraGrouwstra KiaraGrouwstra commented Feb 10, 2024

it looks like nix builds weren't checked yet so far.

i think it fails now tho, i'm now trying to bisect that (edit: see #181).

@YaLTeR
Copy link
Owner

YaLTeR commented Feb 10, 2024

How long does this take? I'd rather the CI time not significantly increased

@KiaraGrouwstra
Copy link
Contributor Author

on the last succeeding commit i had nix build take 1m10s, with similar command nix flake check clocking at 2m37s. (not sure if i had much cached tho, fwiw.)

@YaLTeR
Copy link
Owner

YaLTeR commented Feb 11, 2024

Do you know if it's possible to make it so that failure of the nix job doesn't fail the workflow? There's continue-on-error but apparently it doesn't actually work?

@KiaraGrouwstra
Copy link
Contributor Author

i found a comment there noting that if used on the step level the job will not be marked as failed, which seems to be what you're asking for.
i've added a commit implementing that.
let's see if that works. :)

@KiaraGrouwstra
Copy link
Contributor Author

it does look like the nix job is just a bit slower than the test-release one

@YaLTeR YaLTeR merged commit beaffb1 into YaLTeR:main Feb 12, 2024
7 checks passed
@YaLTeR
Copy link
Owner

YaLTeR commented Feb 12, 2024

Thanks

@YaLTeR
Copy link
Owner

YaLTeR commented Feb 12, 2024

Is it maybe possible to add some caching? To speed it up a little

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants