Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installer: avoid that setup will crash if interrupted / started again #380

Closed
YaWK opened this issue Feb 28, 2023 · 1 comment
Closed

Installer: avoid that setup will crash if interrupted / started again #380

YaWK opened this issue Feb 28, 2023 · 1 comment
Assignees
@YaWK
Labels
BUG Bugs or other unwanted insects FIXED This is fixed
Milestone
Improve Installer...

Comments

@YaWK
Copy link
Owner

YaWK commented Feb 28, 2023 •
edited

After entering db credentials, it was possible to crash the setup process. (If user pressed on browser cancel btn, or reloaded the page during database import) - a faulty installation / faulty database import will now be detected during the setup init process. If that occurs, the installer will delete all db tables to reset the database and re-init the complete setup process again.

This is a huge stability improvement. This avoids an internal server error 500 that could occur during installation in a scenario as described above.
@YaWK YaWK added BUG Bugs or other unwanted insects FIXED This is fixed labels Feb 28, 2023
@YaWK YaWK self-assigned this Feb 28, 2023
YaWK added a commit that referenced this issue Feb 28, 2023
@YaWK
#380: methods to avoid crash on abort; #379 made all fields required …
780b0aa 
…at first
@YaWK
Copy link
Owner Author

YaWK commented Feb 28, 2023

Done - setup won't crash anymore if interrupted before last step.

@YaWK YaWK closed this as completed Feb 28, 2023
@YaWK YaWK mentioned this issue Mar 1, 2023
Closed
YaWK added a commit that referenced this issue Mar 10, 2023
@YaWK
#380: remove setup indicator after successful installation
cf3848f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YaWK YaWK

Labels
BUG Bugs or other unwanted insects FIXED This is fixed
Projects
None yet
Milestone
Improve Installer / Setup Routine
Development

No branches or pull requests
1 participant
@YaWK