feat: add Python 3 support and get ready for conda-forge #43
Conversation
This commit changes a few things that are requires to run the
python code with python 3.x.
- Use print("some str") instead of python "some str" and use the
__future__ import for this.
- Use `except Exception as e` instead of `except Excention, e`
- Use absolute imports instead of relative imports and use the
__future__ import for this.
- Use `@add_metaclass` for metaclasses in _compat.py
- Remove usage of `cmp()`
- Use custom iteritems() instead of dict.iteritems(). This is
added to _compat()
- Add toChar() and toStr() to convert from the type of
`ctypes.c_char_p` to str and vice versa. (Added to _compat.py)
Fixes Yaafe#19
|
I think it's better to add |
|
OK. But, then we need to find a way to solve #41? Any idea? |
|
#44 that is also relevant. |
|
Hi all ! Great work ! Thank you very much. I'm actually abroad for some workshop so I don't have the time yet to look at everything. |
Address Yaafe#41 regarding the use of eigen library from the conda-forge repository. I directly editing the source code without testing it but I think this is correct.
|
@mckelvin I'm not sure to fully understand the way As far as I understand |
Update installation from source given the different Eigen library install method.
@thomasfillon |
|
OK thanks @mckelvin . To get a better understanding, let's say that I use git subtree and push to github. I understand that from my local machine I git subtree will include the git history of the external module. |
|
No, I'll get the subtree information and the git history. https://github.com/mckelvin/python-ta-lib/tree/build-from-source/vendor/ta-lib is an example where When you clone that branch locally ( |
|
As long as Github release archives contain the |
|
OK many thanks @mckelvin for your answer. I now have a much better understanding. |
This pull request starts from @louisabraham and @AbdealiJK work.
conda-forgeautomated build