Possible null pointer exception and app crash during tour book import

[chrgernoe]

In method DatabaseWrapper._checkBitMasks() it is assumed, that if a route is found in the database, the corresponding rock entry also exists. Usually this is ensured by downloading the whole region. However, due to some database inconsistencies at sandsteinklettern.de the rock Deutschland->Sächsische Schweiz->Gebiet der Steine->Kleingießhübler Turm exists twice in the database:

• http://db-sandsteinklettern.gipfelbuch.de/objekt.php?gipfelid=17252 (wrong)
• http://db-sandsteinklettern.gipfelbuch.de/weg.php?gipfelid=4500 (korrekt)

The user tries to import a tour book where the wrong summit is referenced, which does not exists in the app database because of the code in SectorParser.parseRocks():

if (!_CLIMBING_OBJECT_TYPES.contains(type)) {
    continue
}

This leads then to a null pointer exception and an app crash during the import.

The app should handle this case in a proper way without just crashing.

@JoergB2: Is it possible to delete the invalid rock as well as the route entries from the database? There is also a entry in the route table which refers to this rock.

[JoergB2]

Ich habe doppelten Kleingießhübler Turm gelöscht. Das ging nicht ganz einfach, da es da noch eine Begehung zu einem Weg gab, welche erst einmal händisch verschoben werden musste. Theoretisch sollte es nicht vorkommen, das es verwaiste Wege ect. gibt, da ich löschen nicht erlaube, solange es noch etwas zugehöriges gibt. In der Praxis würde ich es aber nicht ausschließen, das sowas in der DB herumgammelt. Sowas sollte aber von einer App abgefangen werden und keinen Absturz verursachen. Gruss Joergh Am 31.05.2021 um 00:39 schrieb Christian Sommer:

…

In method |DatabaseWrapper._checkBitMasks()| it is assumed, that if a route is found in the database, the corresponding rock entry also exists. Usually this is ensured by downloading the whole region. However, due to some database inconsistencies at sandsteinklettern.de <http://sandsteinklettern.de> the rock /Deutschland/->/Sächsische Schweiz/->/Gebiet der Steine/->/Kleingießhübler Turm/ exists twice in the database: * http://db-sandsteinklettern.gipfelbuch.de/objekt.php?gipfelid=17252 (wrong) * http://db-sandsteinklettern.gipfelbuch.de/weg.php?gipfelid=4500 (korrekt) The user tries to import a tour book where the wrong summit is referenced, which does not exists in the app database because of the code in |SectorParser.parseRocks()|: if (!_CLIMBING_OBJECT_TYPES.contains(type)) { continue } This leads then to a null pointer exception and an app crash during the import. The app should handle this case in a proper way without just crashing. @JoergB2 <https://github.com/JoergB2>: Is it possible to delete the wrong entry from the database? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#246>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARBJC2DYWASFTCGEQLVAP6LTQK5D3ANCNFSM45Z2BMUA>.

-- Grundstr. 164 01324 Dresden Tel. 0351/31209495 http://www.joergbrutscher.homepage.t-online.de