Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bug in 3D vertices saver #52

Open
AviP1234 opened this issue Jul 29, 2018 · 1 comment
Open

Small bug in 3D vertices saver #52

AviP1234 opened this issue Jul 29, 2018 · 1 comment

Comments

@AviP1234
Copy link

Hi,
First of all, I would like to thank you for sharing your impressive work.
The released code has a small bug in the 3D vertices saver:
The hight used in the line:
save_vertices[:,1] = h - 1 - save_vertices[:,1]
Is of the pre-cropped image (I.e. if max_size> 1000: image = rescale(image, 1000./max_size) may had a diffrent hight )
To fix the bug just replace the orignal line in the following lines with:
[h1, w1, _] = image.shape
save_vertices[:,1] = h1 - 1 - save_vertices[:,1]
Thank you,
Avi

@PedroOrona
Copy link

If I make this correction I will get a frontal face?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants