Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Commit

Permalink
Fix issue 18: beacon not sent if using https
Browse files Browse the repository at this point in the history
When the page_ready event fires, all event subscribers are called in
order. By default, the order is:

- BOOMR.plugins.RT.done
- BOOMR.plugins.BW.run

each is supposed to call BOOMR.sendBeacon() when done.

The bug in the https flow is that the BW plugin never calls
BOOMR.sendBeacon() in that block.
  • Loading branch information
bluesmoon committed Jan 17, 2012
1 parent 67261ee commit 7c9064f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions boomerang.js
Original file line number Diff line number Diff line change
Expand Up @@ -1237,6 +1237,7 @@ BOOMR.plugins.BW = {

BOOMR.info("HTTPS detected, skipping bandwidth test", "bw");
impl.complete = true;
BOOMR.sendBeacon();
return this;
}

Expand Down

0 comments on commit 7c9064f

Please sign in to comment.