This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Fix issue #18: beacon not sent when using https #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the page_ready event fires, all event subscribers are called in order. By default, the order is: - BOOMR.plugins.RT.done - BOOMR.plugins.BW.run each is supposed to call BOOMR.sendBeacon() when done. The bug in the https flow is that the BW plugin never calls BOOMR.sendBeacon() in that block.
marcelduran
pushed a commit
that referenced
this pull request
Jan 26, 2012
Fix issue #18: beacon not sent when using https
bluesmoon
referenced
this pull request
in bluesmoon/boomerang
Apr 2, 2015
Fixes mem.* properties on browsers that don't support it and download from beacon-blackhole
bluesmoon
referenced
this pull request
in bluesmoon/boomerang
Mar 21, 2016
Fix issue #18: beacon not sent when using https
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the page_ready event fires, all event subscribers are called in
order. By default, the order is:
each is supposed to call BOOMR.sendBeacon() when done.
The bug in the https flow is that the BW plugin never calls
BOOMR.sendBeacon() in that block.