fluxible should be a peer dependency

[lo1tuma]

Currently fluxible is a normal dependency of fluxible-router. As you can see in the flux-examples this can be problem causing two different versions of fluxible in your bundled javascript file.

[mridgway]

Typically npm will hoist the dependency if the versions are the same and only install in the root folder that has the fluxible dependency. Are you seeing it installed twice somewhere?

[lo1tuma]

The problem with that is that you always have to know which version of fluxible is used by fluxible-router and keep them in sync. Using a peerDependency would show you warning during npm install if the version doesn’t match with the version defined in fluxible-router.

In my case I always use exact version numbers in my package.json, so if I depend on fluxible 0.4.8 and fluxible-router depends on ^0.4.9 I will end up with two versions of fluxible.

[mridgway]

Fair point about the warning. We will make that change.

[lo1tuma]

Awesome, thanks 👍.

[mridgway]

Changed in v0.1.8.