Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

Please lower RS log messages for duplicate resources from "info" to "debug" #1238

Closed
jlecomte opened this issue Sep 5, 2013 · 2 comments
Closed

Comments

@jlecomte
Copy link
Contributor

jlecomte commented Sep 5, 2013

Currently, when starting our app, we are getting tons of lines like the following:

info: (mojito-resource-store):
skipping duplicate package yahoo-utils-url
skipping /git-data/apps/search-apps-news/node_modules/yahoo-mojits-search-time-filter/node_modules/yahoo-utils-url
prev used /git-data/apps/search-apps-news/node_modules/yahoo-mojits-search-bread-crumb/node_modules/yahoo-utils-url

Nobody cares about those log messages, they scare n00bs, they hide more important messages, and they are a symptom of an issue with Mojito/YUI, not with the way the app itself is designed (Indeed, the same package often needs to be in multiple parts of the node_modules hierarchy in order to be able to share packages transparently across apps, etc.)

My proposal: drop the log level for those messages from "info" to "debug". Even better would be to have a custom log level for non serious messages emitted by the resource store itself! Not sure whether that's possible...

@caridy
Copy link
Contributor

caridy commented Sep 6, 2013

Makes sense! I will add it to trello.

lzhan pushed a commit that referenced this issue Sep 23, 2013
Fix issue #1238 Please lower RS log messages for duplicate resources from "info" to "debug"
imalberto added a commit to imalberto/mojito that referenced this issue Sep 25, 2013
imalberto added a commit that referenced this issue Sep 25, 2013
@caridy
Copy link
Contributor

caridy commented Mar 3, 2014

This is done in mojito-next (0.9)

@caridy caridy closed this as completed Mar 3, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants