Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

Allow the same context to be used multiple times in configuration #1254

Closed
jlecomte opened this issue Sep 26, 2013 · 6 comments
Closed

Allow the same context to be used multiple times in configuration #1254

jlecomte opened this issue Sep 26, 2013 · 6 comments

Comments

@jlecomte
Copy link
Contributor

Our application configuration is spread across multiple files (we use the "applicationConfigFiles" directive to include additional configuration files into our main application.yaml...) Unfortunately, when the same context is specified multiple times, e.g. "runtime:server,lang:fr-FR", mojito throws an error:

error: (addon-rs-config): 
settings "runtime:server,lang:fr-FR" exists in both 
/blah/blah/blih/base.yaml and
/blah/blah/blah/application.yaml

Because the order matters in the "applicationConfigFiles" directive, we should be allowed to use the same context multiple times. If the same configuration setting is set multiple times, the last one should take precedence...

@drewfish
Copy link
Contributor

Should the last one take precedence, or merge over an earlier one? The merge allows a particular context to be "built up" from multiple files. (Alas, merging arrays is problematic.)

@jlecomte
Copy link
Contributor Author

merge over = take precedence. I don't see the difference...

@drewfish
Copy link
Contributor

I guess I was trying to make a distinction between "replace" and "merge". You seem to have been thinking of "merge" too, so I think we have the same idea 😄.

@jlecomte
Copy link
Contributor Author

Can we prioritize this request? We would like to have it by the end of November/early December. Thanks!

@caridy
Copy link
Contributor

caridy commented Oct 25, 2013

lzhan pushed a commit to lzhan/mojito that referenced this issue Nov 18, 2013
lzhan pushed a commit that referenced this issue Nov 20, 2013
fix issue #1254 Allow the same context to be used multiple times in configuration
@drewfish
Copy link
Contributor

Available in mojito 0.8.1.

lzhan pushed a commit to lzhan/mojito that referenced this issue Dec 23, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants