This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
fix #438 more lightweight resource store adapter #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| source.func = this._getType; | ||
| } else { | ||
| // We don't have any inputs so fail | ||
| throw new Error('There was no "base" or "type" in the "instance" object'); |
There was a problem hiding this comment.
After a throw? I've never seen that before.
There was a problem hiding this comment.
Hmm... that should callback(new Error(...)) instead of throw. I'll make that change.
|
Travis failure is our recurring intermittent |
drewfish
added a commit
that referenced
this pull request
Sep 5, 2012
fix #438 more lightweight resource store adapter
This was referenced Sep 7, 2012
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #438 #76 #77 #78