This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
fix #1017 support for README.md at mojit level #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1824,6 +1824,10 @@ YUI.add('mojito-resource-store', function(Y, NAME) { | |||
| res; | |||
| dir = this._libs.path.resolve(this._config.root, dir); | |||
|
|
|||
| if (!this._libs.fs.lstatSync(dir).isDirectory()) { | |||
There was a problem hiding this comment.
how does this solves the issue? can you elaborate more?
There was a problem hiding this comment.
The original implementation treats every thing under mojits dir as a mojit(dir), it tries to read files under the dir. When README.md file is put under mojits dir, parsing err is thrown. The fix check if it is dir, if it is not, just return, skip the loading process for mojit.
|
+1 TODO:
|
added 3 commits
July 18, 2013 09:24
lzhan
pushed a commit
that referenced
this pull request
Jul 22, 2013
fix #1017 support for README.md at mojit level
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.