Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types for ff_*_multi() copyout overloads #41

Merged

Conversation

reinhrst
Copy link
Contributor

@reinhrst reinhrst commented Dec 1, 2023

I ran into the issue that types.d.ts data is not correct for functions with copyout options. E.g. ff_read_multi() returns [number, Record<number, Packet[]>] in the default call, but [number, Record<number, Packet[]>]

I don't know if this PR fixes the issue in a direction you approve of; things become quite verbose, but I didn't see a quick and simple alternative.

@Yahweasel
Copy link
Owner

I didn't update the types here because I couldn't be bothered to write out exactly these monstrous union types. I don't mind if somebody else writes them for me tho X-D

@Yahweasel Yahweasel merged commit a78ef04 into Yahweasel:master Dec 1, 2023
@reinhrst
Copy link
Contributor Author

reinhrst commented Dec 1, 2023

I didn't update the types here because I couldn't be bothered to write out exactly these monstrous union types. I don't mind if somebody else writes them for me tho X-D

Fair enough :)

@reinhrst reinhrst deleted the typescript-overloads-for-copyouts branch December 2, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants