Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange resizing of Card View #320

Closed
alexgoodison opened this issue Sep 21, 2017 · 10 comments
Closed

Strange resizing of Card View #320

alexgoodison opened this issue Sep 21, 2017 · 10 comments

Comments

@alexgoodison
Copy link

I just started using Koloda and it is perfect except for this one issue. It doesn't happen all the time but it is annoying when it does.

As you can see below, the Koloda Card resizes to a very small size. Once I swipe away this card it goes back to normal.
simulator screen shot 21 sep 2017 23 33 23

This is what it should look like.
simulator screen shot 21 sep 2017 23 33 28

Using Swift 3.1. Tested on iOS 10 but the issue also occurs on iOS 11. Any help appreciated 👍

@IlyaBaudin
Copy link

IlyaBaudin commented Sep 25, 2017

I had same problem in iOS9,10,11

To solution download library for project without cocoapods and remove paddings, insets etc in settings (KolodaView.swift > Default values). This is not correct but I haven't got a time to solve it and understand why it happened.

@longhoang2984
Copy link

The same problem with me:
iOS 11:
img_1141

Another iOS:
img_1143

@IlyaBaudin
Copy link

Did you try this solution??

#295

@longhoang2984
Copy link

I can't see "paddings" in the Koloda source.
What do you means? :(

@IlyaBaudin
Copy link

At first try #295 solution.

@IlyaBaudin
Copy link

About paddings and insets I mean this values:
private let defaultBackgroundCardsTopMargin: CGFloat = 0.0
private let defaultBackgroundCardsScalePercent: CGFloat = 1.00
private let defaultBackgroundCardsLeftMargin: CGFloat = 0.0

For better solution you can create your own KolodaView class and override method frameForCard. It solve my specific issue but I am not sure that it can help all peoples.

@longhoang2984
Copy link

Thank you very much 💯

@IlyaBaudin
Copy link

Did you solve your issue?

@bqmackay
Copy link

bqmackay commented Oct 26, 2017

I'm able to recreate this issue if I reload the cards min-animation. Can anyone verify this on their end as well?

I'll start looking into this more to see if I can resolve it, but I thought I'd put something here in case someone with more knowledge of the codebase has a solution based on this find.

@rnkyr
Copy link
Contributor

rnkyr commented Jan 30, 2018

Hi guys!
Thank you for reporting. I know it's been a while since you've created this issue, but in case anyone still facing it we've merged #259 which fixes the problem.
Feel free to reopen and let us know in case you still can reproduce it

@rnkyr rnkyr closed this as completed Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants