Possible fix for #147 #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…represents many animations that can start/finish before/after each other. 2) The deck layout function can happen during the appear animation causing the card to be whatever size it was during the animation. a) One solution is to layout the deck after the appear animation b) Another is to stop multiple appear animations from happening by checking if we're animating already.
|
@CityTransit Hello, thank you for Pl, it's true a good thing, can you resolve conflict? And I will look at PL closer. |
rnkyr
added
priority: low
status: need feedback
and removed
priority: high
status: work in progress
labels
rnkyr
added
type: bug
priority: high
status: work in progress
and removed
priority: low
status: need feedback
type: enhancement
labels
|
Hi, @CityTransit! |
This was referenced Jan 30, 2018
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Animating as a single boolean doesn't make a ton of sense when it represents many animations that can start/finish before/after each other.
The deck layout function can happen during the appear animation causing the card to be whatever size it was during the animation.
a) One solution is to layout the deck after the appear animation
b) Another is to stop multiple appear animations from happening by checking if we're animating already.
In reference to issues #147 #233