Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate reliance on facebook/pop #435

Open
maxxfrazer opened this issue Jul 15, 2019 · 1 comment
Open

Deprecate reliance on facebook/pop #435

maxxfrazer opened this issue Jul 15, 2019 · 1 comment

Comments

@maxxfrazer
Copy link
Contributor

maxxfrazer commented Jul 15, 2019

Report

A feature request

What do you want to add?

Currently this library relies on facebook/pop, which is no longer being updated by the look of the repository's static pull requests. This is one thing prevents it from being updated for supporting things like Swift Package Manager.

How should it look like?

If the required animations were added directly to this repository (and in Swift), it will prevent any issues as CocoaPods may be phased out in the coming year with Xcode 11.

I'll likely attempt this at some point in the future, but if anyone sees this who maintains or even uses this library and wants to attempt it I'd be very grateful!

I appreciate this may not be something that Yalantis have scope for at the moment; just wanted to list it as an issue for now.

@bilaalrashid
Copy link

Has anyone managed to make any progress on this? I completely agree with @maxxfrazer and I think that this is something that should be of a priority for the community. I have tried to attempt this myself, but with little progress.

I may well try to attempt this again in the future if no one else has done it, as one of my current projects needs to be migrated to Swift Package Manager soon, but I think that it is best that this issue is done by people with more knowledge of the two codebases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants