Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change colors of UI controls #30

Closed
gromiloff opened this issue Feb 10, 2016 · 11 comments
Closed

Change colors of UI controls #30

gromiloff opened this issue Feb 10, 2016 · 11 comments

Comments

@gromiloff
Copy link

Hi, I'm not see methods for setup colors for UI elements such as toolbar, bittons for scale and rotate or icons for close and next.
Does this functionlaity would be implemented or not ?

@shliama
Copy link
Contributor

shliama commented Feb 11, 2016

Most of it is currently supported, please check these issues
#8
#21

@timkoers
Copy link
Contributor

For easy control of the colors at runtime, I have made some changes. Check out my pull request

@gromiloff
Copy link
Author

@shliama @timkoers about toolbar - ok. It.s work, but need to add annotation how override colors:
in color.xml need add next code:

< resources
xmlns:tools="http://schemas.android.com/tools"
tools:override="true">
@color/sickly_yellow
< /resources>

But if change toolbar to more light color - need change color of text and toolbar buttons. This is not supported in your request.

@timkoers
Copy link
Contributor

@alexander That is one of the issues that I am going to fix 😉

Van: Alexander notifications@github.com
verzonden: 16 feb. 2016 10:56 AM
Aan: Yalantis/uCrop
Cc: timkoers
Onderwerp: Re: [uCrop] Change colors of UI controls (#30)

@shliama about toolbar - ok. It.s work, but need to add annotation how override colors:
in color.xml need add next code:

< resources
xmlns:tools="http://schemas.android.com/tools"
tools:override="true">
@color/sickly_yellow
< /resources>

But if change toolbar to more light color - need change color of text and toolbar buttons. This is not supported in your request.


Reply to this email directly or view it on GitHub:
#30 (comment)

@gromiloff
Copy link
Author

@timkoers would be cool 👍

@timkoers
Copy link
Contributor

@agromilo I am testing my code. Your code becomes redundant when the pull request is accepted.

@gromiloff
Copy link
Author

@timkoers this is only warnigs for correct merging resources for users who use this library. By default it's not nessesary, because override resources would done.

@timkoers
Copy link
Contributor

@agromilo If my pull request gets accepted, you'll have full control over the UI colors.

@shliama
Copy link
Contributor

shliama commented Feb 17, 2016

@agromilo your pull request got accepted - check out version 1.2.4 :octocat:

@synram-technolab
Copy link

Just Add this line in your project Color file
<color name="ucrop_color_blaze_orange" tools:override="true">#21AF8F</color>

@fdkitlui
Copy link

fdkitlui commented Nov 26, 2020

Just Add this line in your project Color file
<color name="ucrop_color_blaze_orange" tools:override="true">#21AF8F</color>

we should remove tools:override="true" and just use
<color name="ucrop_color_blaze_orange">#21AF8F</color>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants