Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Freestyle" cropping #32

Closed
franciscofranco opened this issue Feb 14, 2016 · 9 comments
Closed

"Freestyle" cropping #32

franciscofranco opened this issue Feb 14, 2016 · 9 comments
Assignees

Comments

@franciscofranco
Copy link

Can we have a feature to crop a picture freely by dragging the picture corners instead of having to pinch to zoom in/out or changing the aspect ratio?

Thanks!

@shliama
Copy link
Contributor

shliama commented Feb 17, 2016

@franciscofranco Sure you can, please fork & pull-request :octocat:
We're not planning to add this feature at the moment.

@franciscofranco
Copy link
Author

I can try and implement it yeah.
Any special reason why you're not planning to add the feature yourself?

@shliama
Copy link
Contributor

shliama commented Feb 17, 2016

Well, it's implemented like this by-design. Library allows user to choose from various most common aspect ratios.
But it's not really hard to implement "freestyle" cropping - because logic of library doesn't really cares, it's all dynamic.
However at the moment I just have no time to work on this feature.
And here is a power of open-source - you can actually implement it and everyone gonna use it 👍

@developer--
Copy link

Would be great 👍

On Wed, Feb 17, 2016 at 11:51 PM, Oleksii notifications@github.com wrote:

Well, it's implemented like this by-design. Library allows user to choose
from various most common aspect ratios.
But it's not really hard to implement "freestyle" cropping - because logic
of library doesn't really cares, it's all dynamic.
However at the moment I just have no time to work on this feature.
And here is a power of open-source - you can actually implement it and
everyone gonna use it [image: 👍]


Reply to this email directly or view it on GitHub
#32 (comment).

@GameDevLlama
Copy link

@franciscofranco I'd help you with realising that. I'm also missing this feature!
+1

@vxhviet
Copy link

vxhviet commented Apr 8, 2016

@franciscofranco +1 really needed feature :)

@shliama
Copy link
Contributor

shliama commented Apr 20, 2016

I'll try to add this feature in the next update.

@shliama shliama self-assigned this Apr 20, 2016
@shliama
Copy link
Contributor

shliama commented Apr 21, 2016

Introduced the feature in version 1.5.0

@shliama shliama closed this as completed Apr 23, 2016
@sarthak-m
Copy link

Am I missing something? I don't see this feature anymore in the current version 2.2.4
This feature is def. useful for cropping an object out inside of the picture taken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants