Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improve json parse speed by jsony #123

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Conversation

fukusuket
Copy link
Collaborator

@fukusuket fukusuket commented Feb 28, 2024

What Changed

Test

In the integration test below, I confirmed that the all commands succeeded.
https://github.com/Yamato-Security/takajo/actions/runs/8081512762

I would appreciate it if you could check it out when you have time馃檹

@fukusuket
Copy link
Collaborator Author

fukusuket commented Feb 28, 2024

Benchmark

I confirmed that the speed has improved as shown in the Hayabusa results in the log below.
https://github.com/NextronSystems/evtx-baseline/releases/tag/v0.8

Command Version Elapsed time File size
extract-scriptblocks main 47 sec 12260
extract-scriptblocks ThisPR 26 sec 12260
list-ip-addresses main 58 sec 20578
list-ip-addresses ThisPR 32 sec 20578
split-json-timeline main 55 sec ---
split-json-timeline ThisPR 35 sec ---
stack-cmdlines main 48 sec 198064
stack-cmdlines ThisPR 26 sec 198064
stack-logons main 47 sec 46
stack-logons ThisPR 26 sec 46
timeline-partition-diagnostic main 48 sec 6564
timeline-partition-diagnostic ThisPR 26 sec 6564
ttp-summary main 69 sec 46306
ttp-summary ThisPR 33 sec 46306
ttp-visualize main 68 sec 11413
ttp-visualize ThisPR 31 sec 11413

@fukusuket fukusuket added the enhancement New feature or request label Feb 28, 2024
@fukusuket fukusuket added this to the v2.5.0 milestone Feb 28, 2024
@fukusuket fukusuket self-assigned this Feb 28, 2024
@fukusuket fukusuket marked this pull request as ready for review February 28, 2024 15:32
Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fukusuket LGTM! Great improvements! It is now twice as fast in my testing.

Copy link
Collaborator

@hitenkoku hitenkoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hitenkoku hitenkoku merged commit 4592adf into main Feb 29, 2024
2 checks passed
@hitenkoku hitenkoku deleted the 122-improve-speed-by-jsony branch February 29, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve speed by using jsony in JSON parsing
3 participants