Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ietf-*-types missing from repo for IOS XE < 16.5.1 and IOS XR < 6.0.2, 6.1.1 #375

Closed
remingtonc opened this issue Mar 20, 2018 · 3 comments

Comments

@remingtonc
Copy link
Contributor

remingtonc commented Mar 20, 2018

The ietf-inet-types.yang file appears to be missing from:
https://github.com/YangModels/yang/tree/master/vendor/cisco/xe/1631
https://github.com/YangModels/yang/tree/master/vendor/cisco/xe/1632
https://github.com/YangModels/yang/tree/master/vendor/cisco/xe/1641

This yields incomplete parsing.

EDIT:
The types are also not in the folders corresponding to IOS XR versions < 6.0.2. Revised title. This seems to be understood per IOS XE check and IOS XR check. Are items pre-"check"able reasonable to parse? Or something to ignore?

EDIT:
Also missing in IOS XR 6.1.1.

EDIT:
Other ietf-*-types modules are missing in various IOS XE repos as well. ietf-yang-types for instance. Have not validated other repos.

@remingtonc remingtonc changed the title ietf-inet-types.yang missing from IOS XE 16.3.1, 16.3.2, 16.4.1 ietf-inet-types.yang missing from repo for IOS XE 16.3.1, 16.3.2, 16.4.1 Mar 20, 2018
@remingtonc remingtonc changed the title ietf-inet-types.yang missing from repo for IOS XE 16.3.1, 16.3.2, 16.4.1 ietf-inet-types missing from repo for IOS XE < 16.5.1 and IOS XR < 6.0.2 Mar 21, 2018
@remingtonc remingtonc changed the title ietf-inet-types missing from repo for IOS XE < 16.5.1 and IOS XR < 6.0.2 ietf-inet-types missing from repo for IOS XE < 16.5.1 and IOS XR < 6.0.2, 6.1.1 Mar 21, 2018
@remingtonc remingtonc changed the title ietf-inet-types missing from repo for IOS XE < 16.5.1 and IOS XR < 6.0.2, 6.1.1 ietf-*-types missing from repo for IOS XE < 16.5.1 and IOS XR < 6.0.2, 6.1.1 Mar 21, 2018
@einarnn
Copy link
Member

einarnn commented Mar 23, 2018

In the earliest commits of per-OS/platform YANG models we (Cisco) didn't replicate either IETF or OpenConfig models that may have been supported by the platform. We also didn't provide sample XML capability files. The lack of inclusion of the specific versions of dependencies used in a specific OS release turned out to be a mistake that we rectified in subsequent releases. However, we never went back to patch the earlier releases to include the specific 3rd party dependencies.

If you want to put together a PR with the missing models for earlier releases, that would be most welcome!

@remingtonc
Copy link
Contributor Author

Going to let this hang in limbo for a bit as I'm uncertain how to determine what models were present in earlier releases other than this repo.

@einarnn
Copy link
Member

einarnn commented Aug 1, 2020

The obvious answer is to spin up an image (probably XRv or XRv 9000 would be fine) to determine this. But this is really a Cisco issue, not an issue for this repo as such, so closing for now.

@einarnn einarnn closed this as completed Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants