Add missing types files for Cisco releases #581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remingtonc
changed the title
einarnn
reviewed
Apr 4, 2019
There was a problem hiding this comment.
@remingtonc, can you confirm that your commit includes the actual versions these old releases refer to?
|
These are not confirmed to be from the actual versions. These were taken from later releases which did include the models in their respective directories. I will do some due diligence to try and retrieve the actual versions from source. |
This reverts commit d970842.
|
Closing, this is going to get noisy and incorrect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was missing type definitions in early Cisco model releases. This adds missing models which provide those types from later releases which did have those types defined.
This is not verified to be directly from those releases, it adds the models which otherwise were missing for identifying the primitive types of typedefs/imported types/...
Uncertain if this is a good idea.
Recommend squash merge.
Resolves #375