BREAKING! rename default_context::transaction to default_context::def…

…ault_transaction `transaction _;` won't longer be ambiguous when both `ureact` and `ureact::default_context` namespaces are used
YarikTH · Jul 29, 2023 · 16bb76b · 16bb76b
1 parent 3f1ae5e
commit 16bb76b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/include/ureact/transaction.hpp b/include/ureact/transaction.hpp
@@ -82,9 +82,9 @@ namespace default_context
  * @brief Guard class to perform several changes atomically
  *
  */
-struct UREACT_WARN_UNUSED_RESULT transaction : ureact::transaction
+struct UREACT_WARN_UNUSED_RESULT default_transaction : ureact::transaction
 {
-    transaction()
+    default_transaction()
         : ureact::transaction( default_context::get() )
     {}
 };
@@ -101,7 +101,7 @@ template <typename F,
     class = std::enable_if_t<std::is_invocable_v<F&&, Args&&...>>>
 UREACT_WARN_UNUSED_RESULT auto do_transaction( F&& func, Args&&... args )
 {
-    default_context::transaction _;
+    default_transaction _;
 
     if constexpr( std::is_same_v<std::invoke_result_t<F&&, Args&&...>, void> )
     {

diff --git a/tests/src/feature/default_context.cpp b/tests/src/feature/default_context.cpp
@@ -50,7 +50,7 @@ TEST_CASE( "ureact::default_context (transactions)" )
 
     SECTION( "transaction" )
     {
-        transaction _;
+        default_transaction _;
         src <<= 2;
         src <<= 1;
         src <<= 4;