Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make normal library mode (not header-only) #128

Open
YarikTH opened this issue Aug 24, 2023 · 0 comments
Open

Make normal library mode (not header-only) #128

YarikTH opened this issue Aug 24, 2023 · 0 comments

Comments

@YarikTH
Copy link
Owner

YarikTH commented Aug 24, 2023

Description

There is not so much non template code in the library but there is some. According to the compile time benchmarks it allows to spare ~100 ms per cpp in which ureact is included (See #126).

Need to repeat fmtlib approach, where cpp part is in header files, that are just included in header-only mode, while they are included from the library cpp file in library mode. The only difference is - header-only. It keeps ureact's compatibility with godbolt.

Need to make sure that make amalgamated works correctly.

YarikTH added a commit that referenced this issue Aug 24, 2023
YarikTH added a commit that referenced this issue Aug 26, 2023
YarikTH added a commit that referenced this issue Aug 26, 2023
YarikTH added a commit that referenced this issue Aug 26, 2023
YarikTH added a commit that referenced this issue Aug 26, 2023
UREACT_API, UREACT_EXPORT and UREACT_SHARED are ported from `{fmt}`
YarikTH added a commit that referenced this issue Sep 10, 2023
* conditional includes starts with "#   include" and regexp pattern used to discover includes was not ready for it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant