Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Windows #6

Merged
merged 3 commits into from
Nov 1, 2020
Merged

Support Windows #6

merged 3 commits into from
Nov 1, 2020

Conversation

mattn
Copy link
Contributor

@mattn mattn commented Sep 23, 2020

Most of icons does not displayed on Windows Terminal. But it can be solved with another fonts.

image

@Yash-Handa
Copy link
Owner

Thanks very much for the Pull Request, it looks awesome :)

Just one query though,
Is the go-colorable package required for providing true colors on Windows cmd/powershell. I mean does an ASCII escape sequence not work in windows like \033[38;2;125;125;125m or are there some edge cases ?

For your font issue use Nerd-Fonts, this comment has more info regarding it.

@Starz0r
Copy link

Starz0r commented Oct 5, 2020

@Yash-Handa The default PowerShell v5 terminal doesn't have proper ASCII escapes, so the only way to support that is through a package like go-colorable. I believe PowerShell v6 and onwards has native support but I'm unsure, you should mostly rely on terminal implementations that do have it like Windows Terminal or Alacritty.

@Yash-Handa
Copy link
Owner

Thanks @mattn, For such an awesome PR : )

@Yash-Handa Yash-Handa merged commit 483c3a3 into Yash-Handa:master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants