Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command-Line Arguments extensions #33

Merged
merged 3 commits into from Mar 24, 2021
Merged

Conversation

dmk-rib
Copy link
Contributor

@dmk-rib dmk-rib commented Mar 24, 2021

This pull request contains Command-Line Arguments extensions: --password (already exists), --version (msix version), --certificate (path to the certificate).
Msix package is convenient to use for construction of msix in Azure Build Pipeline. But it is not possible to assign an automatically-incremented version and specify the path to the release certificate from CL ...It was added here.

@YehudaKremer, could you make a package with these extensions?

@dmk-rib dmk-rib changed the title Clr args Command-Line Arguments extensions Mar 24, 2021
Copy link
Owner

@YehudaKremer YehudaKremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmk-rib Thank you again for your contributions to this package.

Very nice code!

about: c24dcd2#diff-58bb726ab4bd757fbbba80a3457a5429149a61ffa2bf86f72a4632c04728cd3eR174-R179
we may want to keep the expansion functions in one place (utils.dart)
what do you think?

@YehudaKremer YehudaKremer added the enhancement New feature or request label Mar 24, 2021
@dmk-rib
Copy link
Contributor Author

dmk-rib commented Mar 24, 2021

@YehudaKremer, thank you. It makes sense. One more commit was added

Copy link
Owner

@YehudaKremer YehudaKremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@YehudaKremer YehudaKremer merged commit b9a8bdf into YehudaKremer:main Mar 24, 2021
@YehudaKremer
Copy link
Owner

I'll post a pub new pub version in a few minutes

@YehudaKremer
Copy link
Owner

@dmk-rib i publish new version to pub 1.0.2

thank you again :)

@dmk-rib
Copy link
Contributor Author

dmk-rib commented Mar 24, 2021

Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants