Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Added support for association to multiple file extensions #46

Merged
merged 4 commits into from Jun 17, 2021

Conversation

alexmercerind
Copy link
Contributor

@alexmercerind alexmercerind commented Jun 17, 2021

Now --fe commandline argument can receive args as follows to associate with multiple file extensions. (Separated with commas).

flutter pub run msix:create --fe ogg,ogx,aac,m4a,mp3,wma,wav,aiff,flac,opus

Following section of XML is generated.

          <uap:Extension Category="windows.fileTypeAssociation">
            <uap:FileTypeAssociation Name="fileassociations">
              <uap:SupportedFileTypes>
                <uap:FileType>.ogg</uap:FileType>
                <uap:FileType>.ogx</uap:FileType>
                <uap:FileType>.aac</uap:FileType>
                <uap:FileType>.m4a</uap:FileType>
                <uap:FileType>.mp3</uap:FileType>
                <uap:FileType>.wma</uap:FileType>
                <uap:FileType>.wav</uap:FileType>
                <uap:FileType>.aiff</uap:FileType>
                <uap:FileType>.flac</uap:FileType>
                <uap:FileType>.opus</uap:FileType>
              </uap:SupportedFileTypes>
            </uap:FileTypeAssociation>
          </uap:Extension>

Support for single file extension will keep working the same way.

Notes

  • I have confirmed the functioning.
  • In case the extensions provided by user begin with a period (.), it will be automatically handled.

Lastly, thanks a lot for this great project, really a life saver.

Thankyou.

Look forward for any requested changes to get this merged.

Copy link
Owner

@YehudaKremer YehudaKremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix white space bug:
image

@YehudaKremer YehudaKremer merged commit 3e5a7b7 into YehudaKremer:main Jun 17, 2021
@YehudaKremer YehudaKremer added the enhancement New feature or request label Jun 17, 2021
@YehudaKremer
Copy link
Owner

thank you @alexmercerind for your contribution 👍

@YehudaKremer
Copy link
Owner

version 2.1.3 is now available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants