This repository has been archived by the owner on Jun 30, 2021. It is now read-only.
Use bitflags instead of bitfields for various configs/settings/states #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Each context will now contain a context-specific bitmask containing
proper configuration and ownership information.
- Side-effects: the evhtp struct has been changed to reflect this
new ordering. This removes the following defined variables:
disable_100_cont;
enable_reuseport;
enable_nodelay;
enable_defer_accept;
Use the following bitmask instead:
EVHTP_FLAG_ENABLE_100_CONT (on by defualt)
EVHTP_FLAG_ENABLE_REUSEPORT
EVHTP_FLAG_ENABLE_NODELAY
EVHTP_FLAG_ENABLE_DEFER_ACCEPT
- Optimally, use the evhtp_enable_flag() and or evhtp_set_flags() for
best future uses.
- The following bitflags have been replaced with the following bitmasks inside the connection context. error : EVHTP_CONN_FLAG_ERROR owner : EVHTP_CONN_FLAG_OWNER vhost_via : EVHTP_CONN_FLAG_VHOST_VIA_SNI paused : EVHTP_CONN_FLAG_PAUSED connected : EVHTP_CONN_FLAG_CONNECTED waiting : EVHTP_CONN_FLAG_WAITING free : EVHTP_CONN_FLAG_FREE_CONN keepalive : EVHTP_CONN_FLAG_KEEPALIVE - Side effects: users should not notice any changes, these are mostly internal flags.
- created evhtp_(type)_[enable|diable] functions for setting and unsetting flags for each datatype. - general cleanup.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these are used internally only - but if not - use the following functions now:
evhtp_(enable|disable)_flag:EVHTP_FLAG_ENABLE_100_CONT,EVHTP_FLAG_ENABLE_REUSEPORT.EVHTP_FLAG_ENABLE_NODELAY.EVHTP_FLAG_ENABLE_DEFER_ACCEPT,EVHTP_FLAG_DEFAULTSevhtp_connection_(enable|disable)_flag:EVHTP_CONN_FLAG_ERROR,EVHTP_CONN_FLAG_OWNER,EVHTP_CONN_FLAG_VHOST_VIA_SNI,EVHTP_CONN_FLAG_PAUSED.EVHTP_CONN_FLAG_CONNECTED,EVHTP_CONN_FLAG_WAITING,EVHTP_CONN_FLAG_FREE_CONN.EVHTP_CONN_FLAG_KEEPALIVEevhtp_request_(enable|disable)_flag:EVHTP_REQ_FLAG_KEEPALIVE,EVHTP_REQ_FLAG_FINISHED,EVHTP_REQ_FLAG_CHUNKED,EVHTP_REQ_FLAG_ERROR