Use S3LogsReader with superregion and UTC timezone #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemacysts
approved these changes
Jun 4, 2024
jfongatyelp
added a commit
that referenced
this pull request
Jun 19, 2024
This reverts commit af73799.
EmanElsaban
pushed a commit
that referenced
this pull request
Jun 20, 2024
…keys fix (#980) * Revert "pass around projected SA configs properly" This reverts commit 12b1bf2. * Revert "Merge remote-tracking branch 'origin/u/mpiano/SEC-18955'" This reverts commit ea6376d, reversing changes made to 4038f1e. * Revert "Use S3LogsReader with superregion and UTC timezone (#972)" This reverts commit af73799.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating
yelp_clogthat comes with two changes in S3LogsReader:superregionas a parameter to determine the prefix from where to fetch logs in S3