Add warnings about tronctl disable not being permanent #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we learned in a recent incident, if there are any issues with the DynamoDB data, it's possible for us to end up re-enabling jobs. We've previously warned folks in the past (in Slack/IRC/etc) that to permanently disable jobs it's recommended that they do so in soaconfigs, but this is easy to forget and not everyone will reach out before disabling a job that they don't expect to re-enable any time soon.
EmanElsaban
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we learned in a recent incident, if there are any issues with the DynamoDB data, it's possible for us to end up re-enabling jobs. We've previously warned folks in the past (in Slack/IRC/etc) that to permanently disable jobs it's recommended that they do so in soaconfigs, but this is easy to forget and not everyone will reach out before disabling a job that they don't expect to re-enable any time soon.