feat/Sanitise resource names to ensure they are valid Python identifiers #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean resource names to ensure they:
This is a breaking change, becuase resources which are currently called
My Tag
will now be calledMy_Tag
. For users ofbravado
it will mean workarounds likegetattr(client, 'My Tag').api_method().result()
will need to be replaced withclient.My_Tag.api_method().result()
. I'm not sure what the impact of that change will be on any other libraries which depend onbravado-core
.Fixes Yelp/bravado#307. I have also proposed a different fix for the same problem in Yelp/bravado#320. I'm not sure if it's better to fix this in
bravado-core
orbravado
(or both).