Add log warning for deprecated op #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -215,6 +215,16 @@ def construct_params(self, request, op_kwargs): | |||
| if not remaining_param.required and remaining_param.has_default(): | |||
| marshal_param(remaining_param, None, request) | |||
|
|
|||
| def log_warning_for_deprecated_op(self): | |||
| # TODO: Move this logic to bravado_decorators | |||
| if self.operation.op_spec.get('deprecated'): | |||
There was a problem hiding this comment.
While functionally equivalent, specifying a default value of False here is a little more explicit and in line with the spec
if self.operation.op_spec.get('deprecated', False):
|
Add PR review suggestions. ^ |
prat0318
added a commit
to prat0318/swagger-py
that referenced
this pull request
Jul 18, 2015
|
Moved warning logic to a separate module |
| if rem_date: | ||
| message += "Removal Date: {0}".format(rem_date) | ||
|
|
||
| warnings.warn(message, Warning) |
There was a problem hiding this comment.
If you want to be super explicit, s/Warning/DeprecationWarning
There was a problem hiding this comment.
Used Warning instead of DeprecationWarning, as the latter is by default turned off and hence the warning will get missed.
|
lgtm |
prat0318
force-pushed
the
162_warn_deprecated
branch
from
cc4f543
to
0c538aa
Compare
prat0318
added a commit
that referenced
this pull request
Jul 20, 2015
Add log warning for deprecated op
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #162